[WIP] Check for idle time settings that preventing computing #4634
Conversation
| wxString buffer; | ||
| wxString bufferPIF; //variable to store Processor Idle For string. | ||
| wxString bufferNRI; //variable to store No Recent Input string. | ||
| double startTime, endTime; |
There was a problem hiding this comment.
I recommend to move these two variables close to using - to line 816 (844) to avoid redundant creation if code will hit one of the return false;. And I suggest to initialize them by default
| double startTime, endTime; | |
| double startTime{0.0}, endTime{0.0}; |
There was a problem hiding this comment.
I understand. Because the "suspend when no mouse/keyboard input in last" variable is always enabled, I should just use the usual "buffer" variable for "bufferNRI". BufferPIF can be initialized in the conditional statement.
Your suggested change is not related to the code I modified, but I see your point, I can initialize these variables.
|
There have been significant changes to the preferences settings with #4871. This PR will need significant changes. I'm closing this and will create an issue to track separate PRs. I'll write up the PR in the next couple of days. |
Description of the Change
As I worked on #4600 I found it was possible for a user to set their computing preferences in a way that does not allow any computing. If "suspend when not idle" is enabled, and "suspend if idle for" is set to >0, it is possible for the computer to not process any tasks if the first setting is greater than the second. This commit checks for this condition, and if true, will generate an error message. The user will have to modify one of the values in order to save their preferences.
This PR is a work in progress. The commit only checks for local preferences in BOINC Manger. There are a few things I am not familiar with and could use some assistance:
Also, there are a few small items I would like a second opinion on:
Alternate Designs
This could be modified so the user can accept the settings as-is with an OK/Cancel dialogue box. I don't feel this is needed, if someone wanted to suspend a computer they could do so locally.
Release Notes
Fixed indefinite suspension when times were not set correctly.